Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix DEBUG_HTTP2 type arguments #15197

Closed
wants to merge 1 commit into from
Closed

src: fix DEBUG_HTTP2 type arguments #15197

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 5, 2017

Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, http2

@danbev
src: fix DEBUG_HTTP2 type arguments
52084a6 
Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. labels Sep 5, 2017
@danbev
Copy link
Contributor Author

danbev commented Sep 5, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9945/

jasnell pushed a commit that referenced this pull request Sep 7, 2017
@danbev @jasnell
src: fix DEBUG_HTTP2 type arguments
1df16c6 
Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.

PR-URL: #15197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 7, 2017

Landed in 1df16c6

@jasnell jasnell closed this Sep 7, 2017
@danbev
Copy link
Contributor Author

danbev commented Sep 7, 2017

@jasnell Thanks, I was just about to land it :)

@jasnell
Copy link
Member

jasnell commented Sep 7, 2017

@danbev ... something about great minds thinking alike or some such ;-)

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@danbev @MylesBorins
src: fix DEBUG_HTTP2 type arguments
8fbd341 
Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.

PR-URL: #15197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@danbev @MylesBorins
src: fix DEBUG_HTTP2 type arguments
2881911 
Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.

PR-URL: #15197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@danbev @MylesBorins
src: fix DEBUG_HTTP2 type arguments
7213be9 
Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.

PR-URL: #15197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@danbev @addaleax
src: fix DEBUG_HTTP2 type arguments
ff3e592 
Currently when building using --debug-http2 there are a number of
compilation errors like the following:

In file included from ../src/node_http2.cc:3:
In file included from ../src/node_http2.h:6:
../src/node_http2_core-inl.h:43:32: error: too few arguments to function
call, single argument 'type'
      was not specified
              handle->TypeName(), len, message);

This commit adds the type argument to the calls.

PR-URL: nodejs#15197
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev danbev deleted the http2_debug_type branch November 16, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @jasnell @cjihrig @MylesBorins @nodejs-github-bot