-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a typo in LICENSE #15263
Fixed a typo in LICENSE #15263
Conversation
Line 134: "Copyrighy" instead of "Copyright".
Hi @MKRhere! Welcome (again) and thanks (again)! Just repeating what I said in the PR for folks who end up here rather than there: The typo is in a dependency and so that file will be overwritten the next time we update from the upstream source. The change request should go to the ICU project. You can see the typo in their source tree at http://source.icu-project.org/repos/icu/trunk/icu4c/LICENSE. Their guide on how to contribute to their project is at http://site.icu-project.org/processes/contribute. Hope this helps. |
Thank you @Trott! I couldn't find a way to contribute without being a member, but I could add an ticket on their trac: http://bugs.icu-project.org/trac/ticket/13350 I hope this will be solved and will reflect in Node too. |
Maybe someone on @nodejs/intl knows what to do or is a member and can take care of it. |
@MKRhere ok sorry, i saw this go by but didn't see that it was in ICU. No, please do not change deps/small-icu, it is generated as mentioned. The file is actually not sourced from ICU but yet another embedded source. ICU will be making patch though, so in a future ICU this will be fixed. Thanks. |
MKRhere you said:
OT but I'm curious what you mean. I see @Trott already linked to this page. If there's a way we can improve it, please let me know! @ |
@srl295 I could clone the repository but not push to it. Either way, as long as the patch goes through, it's fine.
This sounds to me like I need to be an ICU Developer and have an account before I can contribute any patches to their source. Anyway the change was trivial enough that any other member can take care of it! |
Line 134: "Copyrighy" instead of "Copyright".
Refer #15261