http2: add tests for push stream error handling #15281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcollina would you mind reviewing this? Thanks! |
mcollina
approved these changes
Sep 13, 2017
| common.skip('missing crypto'); | ||
| const assert = require('assert'); | ||
| const http2 = require('http2'); | ||
|
|
There was a problem hiding this comment.
can you add a quick description of the test here?
| const req = client.request(headers); | ||
|
|
||
| let data = ''; | ||
|
|
There was a problem hiding this comment.
can you please do req.setEncoding('utf8')?
| common.skip('missing crypto'); | ||
| const assert = require('assert'); | ||
| const http2 = require('http2'); | ||
|
|
There was a problem hiding this comment.
Can you add a quick description of this test here?
Add tests that cover errors for wrong arguments, as well as tests for error codes from nghttp2. Fix pushStream to emit NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE on session rather than stream.
apapirovski
force-pushed
the
patch-http2-pushstream-tests
branch
from
2451031
to
64109b3
Compare
|
Thanks @mcollina. Feedback addressed and also rebased just in case. |
jasnell
approved these changes
Sep 13, 2017
|
Landed as 1aca135 |
mcollina
pushed a commit
that referenced
this pull request
Sep 13, 2017
Add tests that cover errors for wrong arguments, as well as tests for error codes from nghttp2. Fix pushStream to emit NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE on session rather than stream. PR-URL: #15281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
Add tests that cover errors for wrong arguments, as well as tests for error codes from nghttp2. Fix pushStream to emit NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE on session rather than stream. PR-URL: nodejs/node#15281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
Add tests that cover errors for wrong arguments, as well as tests for error codes from nghttp2. Fix pushStream to emit NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE on session rather than stream. PR-URL: #15281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
Add tests that cover errors for wrong arguments, as well as tests for error codes from nghttp2. Fix pushStream to emit NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE on session rather than stream. PR-URL: nodejs/node#15281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases for pushStream edge behaviours:
Adds tests that cover errors for wrong arguments, as well as tests for error codes from nghttp2.
Also a test for the method head branch of pushStream (should close writeable stream immediately).
Fixes pushStream to emit NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE on session rather than
stream.
Let me know if there's anything I can change. Thanks!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, test