errors: fix ERR_MODULE_RESOLUTION_LEGACY message #15290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
the
errors
nodejs-github-bot
added
the
errors
bmeck
approved these changes
Sep 9, 2017
lpinca
approved these changes
Sep 9, 2017
Trott
reviewed
Sep 9, 2017
lib/internal/errors.js
Outdated
| @@ -231,7 +231,7 @@ E('ERR_METHOD_NOT_IMPLEMENTED', 'The %s method is not implemented'); | |||
| E('ERR_MISSING_ARGS', missingArgs); | |||
| E('ERR_MISSING_MODULE', 'Cannot find module %s'); | |||
| E('ERR_MODULE_RESOLUTION_LEGACY', '%s not found by import in %s.' + | |||
| 'Legacy behavior in require would have found it at %s'); | |||
| ' Legacy behavior in require would have found it at %s'); | |||
There was a problem hiding this comment.
Question/nit: require -> require()?
There was a problem hiding this comment.
I am okay with that change, @bmeck?
cjihrig
approved these changes
Sep 10, 2017
jasnell
approved these changes
Sep 12, 2017
|
Landed in 6ccb9fe. |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
PR-URL: nodejs#15290 Refs: nodejs#14369 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
This will need to be backported for v8.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #14369
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors