docs: update 8.5.0 changelog #15384
Closed
docs: update 8.5.0 changelog #15384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Sep 13, 2017
|
I don't think this needs to wait 48 hours. If there are no objections I'll be landing it in about 2 hours |
targos
approved these changes
Sep 13, 2017
evanlucas
approved these changes
Sep 13, 2017
jasnell
approved these changes
Sep 13, 2017
|
@MylesBorins would you be so kind and also change https://github.com/nodejs/node/blame/v8.5.0/doc/api/assert.md#L108 to |
BridgeAR
approved these changes
Sep 13, 2017
The original changelog included incorrect information regarding the new perf_hooks api. refs: nodejs#15308 (comment)
MylesBorins
force-pushed
the
update-8.5.0-change-log
branch
from
b46ad0b
to
366153e
Compare
|
@BridgeAR done... please review |
BridgeAR
approved these changes
Sep 13, 2017
|
Thanks! |
|
I do not think that this has to wait the regular 48 hours. |
MylesBorins
added a commit
that referenced
this pull request
Sep 14, 2017
The original changelog included incorrect information regarding the new perf_hooks api. refs: #15308 (comment) PR-URL: #15384 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
landed in cba206f |
MylesBorins
added a commit
that referenced
this pull request
Sep 14, 2017
The original changelog included incorrect information regarding the new perf_hooks api. refs: #15308 (comment) PR-URL: #15384 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
The original changelog included incorrect information regarding the new perf_hooks api. refs: nodejs/node#15308 (comment) PR-URL: nodejs/node#15384 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
The original changelog included incorrect information regarding the new perf_hooks api. refs: nodejs/node#15308 (comment) PR-URL: nodejs/node#15384 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original changelog included incorrect information regarding
the new perf_hooks api.
refs: #15308 (comment)