Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: revert #14024 writable is never set to false #15404

Closed
wants to merge 1 commit into from
Closed

http: revert #14024 writable is never set to false #15404

wants to merge 1 commit into from

Commits on Sep 20, 2017

  1. http: revert nodejs#14024 writable is never set to false 

    Setting writable = false in IncomingMessage.end made some errors
being swallowed in some very popular OSS libraries that we must
support. This commit add some of those use cases to the tests,
so we avoid further regressions.
We should reevaluate how to set writable = false in IncomingMessage
in a way that does not break the ecosystem.

See: nodejs#14024
Fixes: nodejs#15029
    @mcollina
    mcollina committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    cccf934 View commit details
    Browse the repository at this point in the history