Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use UV_EINVAL instead of EINVAL in udp_wrap #15444

Closed
wants to merge 5 commits into from
Closed

src: use UV_EINVAL instead of EINVAL in udp_wrap #15444

wants to merge 5 commits into from

Commits on Sep 20, 2017

  1. src: use UV_EINVAL instead of EINVAL in udp_wrap 

    Currently if the buffer size exceeds the maximum int size the following
error will be thrown:
dgram.js:180
    throw new errors.Error('ERR_SOCKET_BUFFER_SIZE', e);
    ^

Error [ERR_SOCKET_BUFFER_SIZE]: Could not get or set buffer size: Error:
Unknown system error 22: Unknown system error 22, uv_recv_buffer_size
    at bufferSize (dgram.js:180:11)

It looks like perhaps UV_EINVAL was intended to give the following error
message instead:
dgram.js:180
    throw new errors.Error('ERR_SOCKET_BUFFER_SIZE', e);
    ^

Error [ERR_SOCKET_BUFFER_SIZE]: Could not get or set buffer size: Error:
EINVAL: invalid argument, uv_recv_buffer_size
    at bufferSize (dgram.js:180:11)

This commit changes EINVAL to use UV_EINVAL.
    @danbev
    danbev committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    b06909f View commit details
    Browse the repository at this point in the history

  2. squash: add test for recv/send buffer sizes

    @danbev
    danbev committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    5178868 View commit details
    Browse the repository at this point in the history

  3. squash: use string instread of a regexp

    @danbev
    danbev committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    2a76b64 View commit details
    Browse the repository at this point in the history

  4. squash: use string template

    @danbev
    danbev committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    dfc29b2 View commit details
    Browse the repository at this point in the history

  5. squash: remove eslint ignore rule

    @danbev
    danbev committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    b87360c View commit details
    Browse the repository at this point in the history