Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Http2Stream destroyed handling #15461

Closed
wants to merge 2 commits into from
Closed

test: Http2Stream destroyed handling #15461

wants to merge 2 commits into from

Conversation

ssbrewster
Copy link
Contributor

This PR includes a few test cases for the handling of stream.session.destroy() within the Http2Stream class.

Refs: #14985

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 18, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Sep 18, 2017
@mcollina
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10135/

@ssbrewster
Copy link
Contributor Author

There are some lint errors with make lint (linter stopped working in my IDE for some reason :/). I'll clean them up.

@ssbrewster
Copy link
Contributor Author

Those lint fixes are done @jasnell @mcollina please can you review again?

@mcollina
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10158/

mcollina
mcollina approved these changes Sep 20, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

Landed as 6c38ab3.

@mcollina mcollina closed this Sep 20, 2017
mcollina pushed a commit that referenced this pull request Sep 20, 2017
@ssbrewster @mcollina
http2: improved coverage of Http2Stream destroy
6c38ab3 
Refs: #14985
PR-URL: #15461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@ssbrewster @jasnell
http2: improved coverage of Http2Stream destroy
66a5f99 
Refs: #14985
PR-URL: #15461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
@ssbrewster ssbrewster deleted the http2-test-coverage branch September 21, 2017 07:35
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@ssbrewster
http2: improved coverage of Http2Stream destroy
65aceb2 
Refs: nodejs/node#14985
PR-URL: nodejs/node#15461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@ssbrewster
http2: improved coverage of Http2Stream destroy
eac8145 
Refs: nodejs/node#14985
PR-URL: nodejs/node#15461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ssbrewster @mcollina @jasnell @mscdex @MylesBorins @nodejs-github-bot