fs: validate fd on fs.write #1553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -779,6 +779,9 @@ static void Open(const FunctionCallbackInfo<Value>& args) { | |||
| static void WriteBuffer(const FunctionCallbackInfo<Value>& args) { | |||
| Environment* env = Environment::GetCurrent(args); | |||
|
|
|||
| if (!args[0]->IsInt32()) | |||
| return env->ThrowTypeError("First argument must be file descriptor"); | |||
|
|
|||
| CHECK(args[0]->IsInt32()); | |||
There was a problem hiding this comment.
Is this check still required?
|
@cjihrig fixed PR with your suggestions |
|
LGTM |
julianduque
added a commit
that referenced
this pull request
Apr 28, 2015
PR-URL: #1553 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in f9c681c |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Apr 29, 2015
PR-URL: nodejs#1553 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 14, 2015
PR-URL: nodejs#1553 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / f9c681c Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1550