test: extend timeouts for ARMv6 #1554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The x6 factor was already very generous, it surprises me a bit that you still have issues. I suspect your SD must be of a very slow kind or something. LGTM, if it helps. |
|
could be .. one of the Pi's particularly has an older SD card. An alternative to raising it to 7 is going through the individual tests that have been failing and extending them rather than doing the whole lot. |
|
I went through ccache statistics on all the PI's. They have a very high hitrate – so getting faster storage would probably be the best solution :/ |
|
If I remember correctly, the RPi doesn't have a dedicated storage controller, so all SD access is done on the CPU, which puts a hard limit on the transfer rate you can get. I'm fine with x7 myself. |
rvagg
added a commit
that referenced
this pull request
Apr 29, 2015
Based on tests running on original Raspberry Pi PR-URL: #1554 Reviewed-By: Roman Reiss <me@silverwind.io>
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Apr 29, 2015
Based on tests running on original Raspberry Pi PR-URL: nodejs#1554 Reviewed-By: Roman Reiss <me@silverwind.io>
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 14, 2015
Based on tests running on original Raspberry Pi PR-URL: nodejs#1554 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / f9b226c Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I suspect the ARMv6 timeouts introduced by @silverwind were based on a Pi B+ or similar or perhaps an overclocked Pi. The CI cluster has 2 x original Pi's and 1 x Pi B+ and the tests don't consistently pass on the older Pi's.
This configuration gives me all passes but I'd appreciate review by @silverwind and anyone else familiar with the specific tests I've adjusted: test-child-process-fork-net2.js, test-debug-signal-cluster.js, test-next-tick-error-spin.js