build: remove support for VS 2010 and 2012 #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can't compile io.js anyway.
|
Looks reasonable to me. @piscisaureus? |
|
Lgtm Verzonden van mijn HTC ----- Reply message ----- Looks reasonable to me. @piscisaureushttps://github.com/piscisaureus? Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-66822771. |
chrisdickinson
pushed a commit
that referenced
this pull request
Dec 12, 2014
They can't compile io.js anyway. PR-URL: #156 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Bert Belder <bertbelder@gmail.com>
|
Merged in 370e821. Thanks! |
2 tasks
This was referenced Jan 31, 2020
This was referenced Sep 28, 2021
This was referenced Nov 30, 2023
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Dec 5, 2023
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
# Conflicts: # test/parallel/parallel.status
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
# Conflicts: # test/parallel/parallel.status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can't compile io.js anyway.