Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/https: convert to using internal/errors #15603

Closed
wants to merge 1 commit into from
Closed

lib/https: convert to using internal/errors #15603

wants to merge 1 commit into from

Conversation

ramimoshe
Copy link
Contributor

covert lib/https.js over to using lib/internal/errors.js

ref: #11273

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. https Issues or PRs related to the https subsystem. labels Sep 25, 2017
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 25, 2017
lpinca
lpinca reviewed Sep 26, 2017
View reviewed changes
doc/api/errors.md Outdated
### ERR_HTTP_NO_DOMAIN

An error using the `'ERR_HTTP_NO_DOMAIN'` code is thrown specifically when an attempt
is made to parse an URL without a valid domain name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: "a URL".

@lpinca lpinca mentioned this pull request Sep 27, 2017
Closed
4 tasks
@ramimoshe
Copy link
Contributor Author

Hi, who is responsible to merge this pr?

@lpinca
Copy link
Member

lpinca commented Sep 27, 2017

@ramimoshe any collaborator can land a PR but we wait for 48+ h to make sure everyone had a chance to look at it.

@BridgeAR
Copy link
Member

Is this code currently not covered? In that case it would be great to add a new test.

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/10306/

@BridgeAR BridgeAR requested a review from a team September 28, 2017 05:43
BridgeAR
BridgeAR requested changes Sep 28, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the already existing error type ERR_INVALID_DOMAIN_NAME instead of adding a redundant new one.

BridgeAR
BridgeAR approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though I would strongly prefer to have a test added for this case before landing.

@BridgeAR
Copy link
Member

@ramimoshe would you be so kind and add a test for this as well? That would be really great. If you need any help, please let me know.

indutny
indutny approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@indutny indutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell jasnell mentioned this pull request Sep 28, 2017
Closed
80 tasks
@Trott
Copy link
Member

Trott commented Sep 29, 2017 •
edited
Loading

@BridgeAR This code is indeed covered in tests. test/parallel/test-http-invalid-urls.js: will exercise it. Unfortunately, that test appears buggy. It makes the perfectly reasonable but incorrect assumption that if the second argument in assert.throws() is a string, then it corresponds to the expected message. Alas, no. (This gotcha is documented.)

IMO, this PR should fix that test. This line:

const error = 'Unable to determine the domain name';

...should be changed to something like this:

const error = common.expectsError({code: 'ERR_INVALID_DOMAIN_NAME'});

(Maybe include the message property too? Maybe change the name from error to something like expectedError? But those improvements can happen subsequently, if at all.)

@Trott
Copy link
Member

Trott commented Sep 29, 2017

(Also, this will need a CI run before landing, of course.)

@Trott
Copy link
Member

Trott commented Sep 29, 2017

(Actually, I'm inclined to CI this now, land it, and then PR the test fix myself. If @ramimoshe wants to learn all about how we write our tests and stuff, awesome. But I'm going to avoid piling on changes for a first-time contribution.)

@Trott
Copy link
Member

Trott commented Sep 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10328/

@Trott
Copy link
Member

Trott commented Sep 29, 2017

Hmmm....merge conflicts even though GitHub doesn't seem to notice them.

Squashed, rebased, force-pushed. Trying again.

CI: https://ci.nodejs.org/job/node-test-pull-request/10329/

@Trott
Copy link
Member

Trott commented Sep 29, 2017

Landed in 4843c2f

@Trott Trott closed this Sep 29, 2017
Trott pushed a commit that referenced this pull request Sep 29, 2017
@Trott
https: convert to using internal/errors
4843c2f 
PR-URL: #15603
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@Trott
Copy link
Member

Trott commented Sep 29, 2017

Welcome @ramimoshe and thanks for the contribution! 🎉

@ramimoshe
Copy link
Contributor Author

Thanks everyone :)
Why did you close the PR without "merge"?

@ramimoshe
Copy link
Contributor Author

BTW I will try to add tests in my other open PR

@lpinca
Copy link
Member

lpinca commented Sep 29, 2017

@ramimoshe that's how we land PRs you can find more info on the process in our documentation.
@Trott already opened a PR for the test. See #15678.

addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@addaleax
https: convert to using internal/errors
242a622 
PR-URL: nodejs/node#15603
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@hiroppy hiroppy hiroppy approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@indutny indutny indutny approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. https Issues or PRs related to the https subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ramimoshe @lpinca @BridgeAR @Trott @indutny @jasnell @hiroppy @nodejs-github-bot