Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix style bug on version link dropdown #15671

Closed
wants to merge 1 commit into from

Conversation

chris--young
Copy link

I noticed a minor styling bug while working on #15670 that this pr will fix.

Before:
screen shot 2017-09-28 at 6 23 42 pm

After:
screen shot 2017-09-28 at 6 23 30 pm

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 29, 2017
@silverwind
Copy link
Contributor

I also noticed this and included some fixes for it in #15660, thought my approach is a bit different. I set box-sizing: border-box, fixed the #gtoc li selector so it doesn't affect the dropdown and then cleaned up the style of ol.version-picker.

@chris--young
Copy link
Author

That’s cool. I have no strong opinions one way or the other, would just like to see whatever approach we go with make it into the back port to v6.

I did already sneak this into #15670

@silverwind
Copy link
Contributor

silverwind commented Sep 29, 2017

I think the approach here is not the right one. The root of the issue is that #gtoc li affects the dropdown items while it should not. Changing the selector #gtoc li to #gtoc > ul > li is a better fix. If you'd like to change this here, I will remove the change in my other PR.

@chris--young
Copy link
Author

Let’s keep it in your’s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants