Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace fixturesdir use common.fixtures #15973

Closed
wants to merge 5 commits into from
Closed

test: replace fixturesdir use common.fixtures #15973

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e010f9c
test: replace fixturesdir use common.fixtures
pauljohnberry Oct 6, 2017
c117347
test: replace fixturesdir use common.fixtures
pauljohnberry Oct 6, 2017
86dd0dc
test: replace resolve use path method
pauljohnberry Oct 6, 2017
5f5da58
test: remove unused var path
pauljohnberry Oct 7, 2017
963a833
test: removal of new line
pauljohnberry Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/parallel/test-http2-respond-file-fd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
Expand All @@ -13,7 +14,8 @@ const {
HTTP2_HEADER_CONTENT_LENGTH
} = http2.constants;

const fname = path.resolve(common.fixturesDir, 'elipses.txt');
const fname = path.resolve(fixtures.path(), 'elipses.txt');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.path

Copy link
Contributor Author

@pauljohnberry pauljohnberry Oct 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, you mean instead of path.resolve? wanted to limit changes as fixtures.path uses path.join in the background rather than resolve. so: const fname = fixtures.path('elipses.txt');


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This does not really need the newline IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tniessen I agree, removed now.

const data = fs.readFileSync(fname);
const stat = fs.statSync(fname);
const fd = fs.openSync(fname, 'r');
Expand Down