doc: public keys don't accept passphrases #16087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
2 tasks
cjihrig
approved these changes
Oct 8, 2017
addaleax
approved these changes
Oct 8, 2017
seishun
suggested changes
Oct 8, 2017
There was a problem hiding this comment.
While crypto.publicDecrypt() and crypto.publicEncrypt() do accept a passphrase option, the C++ code simply ignores it because OpenSSL does not support it for public keys.
It does support it for private keys, and you can call both crypto.publicDecrypt() and crypto.publicEncrypt() with a private key, which will fail if it's encrypted and you don't provide a passphrase.
> var key = fs.readFileSync('private.pem', {encoding: 'ascii'});
> var data = new Buffer(15)
> crypto.publicEncrypt(key, data)
Error: error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt
at Object.publicEncrypt (crypto.js:388:12)
at repl:1:8
at ContextifyScript.Script.runInThisContext (vm.js:44:33)
at REPLServer.defaultEval (repl.js:239:29)
at bound (domain.js:301:14)
at REPLServer.runBound [as eval] (domain.js:314:12)
at REPLServer.onLine (repl.js:433:10)
at emitOne (events.js:120:20)
at REPLServer.emit (events.js:210:7)
at REPLServer.Interface._onLine (readline.js:278:10)
> crypto.publicEncrypt({ key: key, passphrase: 'whatever'}, data)
<Buffer 74 49 d9 b7 6b fe 8a 1a 53 0d c2 46 8f 75 7c b4 34 cf f0 4a b6 11 df 43 c8 8b e2 bc 1c f1 30 cd 95 2a 19 2f 82 87 4f 4f 6a 15 ca b5 16 9c 23 1c f5 8f ... >
>Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. Refs: nodejs#16038
bnoordhuis
force-pushed
the
undocument-passphrase-option
branch
from
b60a804
to
3cdd070
Compare
|
Okay, fair enough. I rewrote it more rigorously, PTAL. |
seishun
approved these changes
Oct 8, 2017
tniessen
approved these changes
Oct 9, 2017
danbev
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 10, 2017
BridgeAR
approved these changes
Oct 18, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 18, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: #16087 Ref: #16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 3469eb9 |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: #16087 Ref: #16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: nodejs/node#16087 Ref: nodejs/node#16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Since `crypto.publicDecrypt()` and `crypto.publicEncrypt()` accept both public and private keys, make it clear that the `passphrase` option only applies to private keys. PR-URL: nodejs/node#16087 Ref: nodejs/node#16038 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
crypto.publicDecrypt()andcrypto.publicEncrypt()do accept apassphraseoption, the C++ code simply ignores it because OpenSSL doesnot support it for public keys. Undocument the option.
Refs: #16038