buffer: add indexOf/lastIndexOf method #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `.indexOf` method to `Buffer`, which borrows semantics from both `Array.prototype.indexOf` and `String.prototype.indexOf`. `Buffer.prototype.indexOf` can be invoked with a Buffer, a string or a number as the needle. If the needle a Buffer or string, it will find the first occurrence of this sequence of bytes. If the needle is a number, it will find the first occurrence of this byte. Reviewed-by: Sam Rijs <srijs@airpost.net> Fixes: #95 PR-URL: #160
Expanding and reusing code by Sam Rijs in commit 4dedc09 to also add a `.lastIndexOf` method to `Buffer`. `Buffer.prototype.lastIndexOf` takes the same arguments as its predecessor and uses a divide-and-conquer method to find the last occurrence of the sequence of byte. Reviewed-by: Martin Algesten <martin@algesten.se> Related-To: #95 Original PR-URL: #160 PR-URL: #161
rvagg
added
the
semver-minor
|
I have no opinion on the subject but from what I'm seeing is that #561 will supersede this PR. However, it has been indicated that there will be no I'm unsure with how to proceed with this specific PR, as only one commit seems to be prevalent now. @algesten? |
|
I'm really sorry. Been tied up with work, which is why I haven't finished my |
|
Closing this in favor of #561. @algesten, if you're interested in adding |
|
Thanks @chrisdickinson I'll try to make some time to look into it. |
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
This was referenced May 26, 2021
This was referenced Nov 30, 2023
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Dec 5, 2023
V8 will increase the maximum TypedArray size in https://crrev.com/c/4872536; this CL adapts the tests to allow for that. Tests that hard-code smaller sizes or are already tested in V8 are removed; one test is adapted to not rely on a specific limit. # Conflicts: # test/parallel/test-buffer-alloc.js # test/parallel/test-buffer-tostring-rangeerror.js
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
V8 will increase the maximum TypedArray size in https://crrev.com/c/4872536; this CL adapts the tests to allow for that. Tests that hard-code smaller sizes or are already tested in V8 are removed; one test is adapted to not rely on a specific limit. # Conflicts: # test/parallel/test-buffer-alloc.js # test/parallel/test-buffer-tostring-rangeerror.js
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
V8 will increase the maximum TypedArray size in https://crrev.com/c/4872536; this CL adapts the tests to allow for that. Tests that hard-code smaller sizes or are already tested in V8 are removed; one test is adapted to not rely on a specific limit. # Conflicts: # test/parallel/test-buffer-alloc.js # test/parallel/test-buffer-tostring-rangeerror.js
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
V8 will increase the maximum TypedArray size in https://crrev.com/c/4872536; this CL adapts the tests to allow for that. Tests that hard-code smaller sizes or are already tested in V8 are removed; one test is adapted to not rely on a specific limit. # Conflicts: # test/parallel/test-buffer-alloc.js # test/parallel/test-buffer-tostring-rangeerror.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded on @srijs code to add a
Buffer.prototype.lastIndexOf. I used a strategy of divide/conquer, but since I'm a total c++ idiot, I have no idea whether there is a better way (some reverse memcmp variant?). Also I rebased both srijs and these commits against v0.12 hoping it would make it out sooner :)