http: allow http.request() over tls #1616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanashworth
added
http
brendanashworth
changed the title
|
Going to solicit @nodejs/tsc for opinions / review |
brendanashworth
force-pushed
the
new/http-request-over-https
branch
from
c6fc95d
to
c684315
Compare
This commit refractors the Agent implementation into the respective HTTP submodules. For backwards compatibility, some changes were made to the https default agent. A developer can enable HTTPS by default for all requests by setting: http.globalAgent.protocol = 'https:'
brendanashworth
force-pushed
the
new/http-request-over-https
branch
from
c684315
to
509f38a
Compare
|
I guess there isn't interest in having this right now, so I'll close it and leave the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refractors all the HTTPS request logic into the respective HTTP files, leaving only backwards compatibility stuff. Users choose by passing
protocolin thehttp.requestoptions, or by the respective agent. See iojs/NG#12.No code was deprecated, but
https.Agentwas deprecated (only in the documentation) in favor ofhttp.Agent, which it is now just a reference to. I had to edit one test because it sniffed error messages (I made it more general now), I hope that doesn't make thissemver-major.... and if you're feeling adventurous: