Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor away test/inspector #16197

Closed
wants to merge 2 commits into from
Closed

refactor away test/inspector #16197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e5a794
test: move inspector tests to parallel/sequential
maclover7 Oct 14, 2017
efa5d10
test: remove inspector directory artifacts
maclover7 Oct 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,6 @@ test-pummel: all
test-internet: all
$(PYTHON) tools/test.py internet

test-inspector: all
$(PYTHON) tools/test.py inspector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove it from vcbuild.bat? (Two mentions.)


test-node-inspect: $(NODE_EXE)
USE_EMBEDDED_NODE_INSPECT=1 $(NODE) tools/test-npm-package \
--install deps/node-inspect test
Expand Down
1 change: 0 additions & 1 deletion test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ On how to run tests in this directory, see
|es-module |Yes |Test ESM module loading.|
|fixtures | |Test fixtures used in various tests throughout the test suite.|
|gc |No |Tests for garbage collection related functionality.|
|inspector |Yes |Tests for the V8 inspector integration.|
|internet |No |Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.|
|known_issues |Yes |Tests reproducing known issues within the system. All tests inside of this directory are expected to fail consistently. If a test doesn't fail on certain platforms, those should be skipped via `known_issues.status`.|
|message |Yes |Tests for messages that are output for various conditions (```console.log```, error messages etc.)|
Expand Down
0 test/inspector/inspector-helper.js → test/common/inspector-helper.js
View file
Open in desktop
File renamed without changes.
0 test/inspector/global-function.js → test/fixtures/inspector-global-function.js
View file
Open in desktop
File renamed without changes.
16 changes: 0 additions & 16 deletions test/inspector/inspector.status
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions test/inspector/testcfg.py
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ prefix parallel
[true] # This section applies to all platforms

[$system==win32]
test-inspector-bindings : PASS, FLAKY
test-inspector-debug-end : PASS, FLAKY
test-inspector-stop-profile-after-done: PASS, FLAKY

[$system==linux]

Expand All @@ -19,3 +22,5 @@ test-npm-install: PASS,FLAKY

[$system==freebsd]

[$system==aix]
test-inspector-stop-profile-after-done: PASS, FLAKY
2 changes: 1 addition & 1 deletion ...ector/test-async-hook-setup-at-inspect.js → ...st-inspect-async-hook-setup-at-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('../inspector/inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');

// Even with --inspect, the default async call stack depth is 0. We need a
Expand Down
2 changes: 1 addition & 1 deletion ...r/test-async-hook-setup-at-inspect-brk.js → ...pector-async-hook-setup-at-inspect-brk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');

const script = `
Expand Down
2 changes: 1 addition & 1 deletion ...pector/test-async-hook-setup-at-signal.js → ...t-inspector-async-hook-setup-at-signal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('../inspector/inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');

const script = `
Expand Down
0 .../test-async-hook-teardown-at-debug-end.js → ...ector-async-hook-teardown-at-debug-end.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...r/test-async-stack-traces-promise-then.js → ...pector-async-stack-traces-promise-then.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper');
const { NodeInstance } = require('../common/inspector-helper');
const assert = require('assert');

const script = `runTest();
Expand Down
2 changes: 1 addition & 1 deletion ...r/test-async-stack-traces-set-interval.js → ...pector-async-stack-traces-set-interval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper');
const { NodeInstance } = require('../common/inspector-helper');
const assert = require('assert');

const script = 'setInterval(() => { debugger; }, 50);';
Expand Down
0 test/inspector/test-bindings.js → test/parallel/test-inspector-bindings.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/inspector/test-inspector-break-e.js → test/parallel/test-inspector-break-e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');

async function runTests() {
const instance = new NodeInstance(undefined, 'console.log(10)');
Expand Down
6 changes: 3 additions & 3 deletions test/inspector/test-break-when-eval.js → ...arallel/test-inspector-break-when-eval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const path = require('path');
const { NodeInstance } = require('../common/inspector-helper.js');
const fixtures = require('../common/fixtures');

const script = path.join(path.dirname(module.filename), 'global-function.js');
const script = fixtures.path('inspector-global-function.js');

async function setupDebugger(session) {
console.log('[test]', 'Setting up a debugger');
Expand Down
0 test/inspector/test-contexts.js → test/parallel/test-inspector-contexts.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/inspector/test-debug-brk-flag.js → ...parallel/test-inspector-debug-brk-flag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ common.skipIfInspectorDisabled();

const assert = require('assert');
const { mainScriptPath,
NodeInstance } = require('./inspector-helper.js');
NodeInstance } = require('../common/inspector-helper.js');

async function testBreakpointOnStart(session) {
const commands = [
Expand Down
2 changes: 1 addition & 1 deletion test/inspector/test-debug-end.js → test/parallel/test-inspector-debug-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common');
common.skipIfInspectorDisabled();
const { strictEqual } = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');

async function testNoServerNoCrash() {
console.log('Test there\'s no crash stopping server that was not started');
Expand Down
2 changes: 1 addition & 1 deletion test/inspector/test-exception.js → test/parallel/test-inspector-exception.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled();

const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');

const script = fixtures.path('throws_error.js');

Expand Down
2 changes: 1 addition & 1 deletion test/inspector/test-ip-detection.js → test/parallel/test-inspector-ip-detection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const os = require('os');

const ip = pickIPv4Address();
Expand Down
2 changes: 1 addition & 1 deletion test/inspector/test-not-blocked-on-idle.js → ...lel/test-inspector-not-blocked-on-idle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
common.skipIfInspectorDisabled();
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');

async function runTests() {
const script = 'setInterval(() => {debugger;}, 60000);';
Expand Down
0 test/inspector/test-port-zero-cluster.js → ...allel/test-inspector-port-zero-cluster.js
View file
Open in desktop
File renamed without changes.
0 test/inspector/test-port-zero.js → test/parallel/test-inspector-port-zero.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/inspector/test-scriptparsed-context.js → ...el/test-inspector-scriptparsed-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common');
common.skipIfInspectorDisabled();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');

const script = `
Expand Down
2 changes: 1 addition & 1 deletion ...inspector/test-stop-profile-after-done.js → ...test-inspector-stop-profile-after-done.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');

async function runTests() {
const child = new NodeInstance(['--inspect=0'],
Expand Down
0 test/inspector/test-stops-no-file.js → .../parallel/test-inspector-stops-no-file.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/inspector/test-inspector.js → test/parallel/test-inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ common.skipIfInspectorDisabled();
const assert = require('assert');
const { mainScriptPath,
readMainScriptSource,
NodeInstance } = require('./inspector-helper.js');
NodeInstance } = require('../common/inspector-helper.js');

function checkListResponse(response) {
assert.strictEqual(1, response.length);
Expand Down
0 test/inspector/test-inspector-enabled.js → test/sequential/test-inspector-enabled.js
View file
Open in desktop
File renamed without changes.
0 test/inspector/test-port-cluster.js → ...sequential/test-inspector-port-cluster.js
View file
Open in desktop
File renamed without changes.
3 changes: 1 addition & 2 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ if /i "%1"=="test-addons-napi" set test_args=%test_args% addons-napi&set build
if /i "%1"=="test-simple" set test_args=%test_args% sequential parallel -J&goto arg-ok
if /i "%1"=="test-message" set test_args=%test_args% message&goto arg-ok
if /i "%1"=="test-gc" set test_args=%test_args% gc&set build_testgc_addon=1&goto arg-ok
if /i "%1"=="test-inspector" set test_args=%test_args% inspector&goto arg-ok
if /i "%1"=="test-tick-processor" set test_args=%test_args% tick-processor&goto arg-ok
if /i "%1"=="test-internet" set test_args=%test_args% internet&goto arg-ok
if /i "%1"=="test-pummel" set test_args=%test_args% pummel&goto arg-ok
Expand Down Expand Up @@ -529,7 +528,7 @@ echo Failed to create vc project files.
goto exit

:help
echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-inspector/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
echo Examples:
echo vcbuild.bat : builds release build
echo vcbuild.bat debug : builds debug build
Expand Down