Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v2.0.1 #1629

Closed
wants to merge 1 commit into from
Closed

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 7, 2015

I'm surprised we haven't had a flurry of "you broke my stuff!!" issues yet the issue & fix that concerns me the most is the NODE_DEPRECATED macro causing problems with older compilers, see #1626. I'd like to see the fix for this get out sooner rather than later. So I'm proposing a release in ~48 hours from now.

  • [7dde95a8bd] - async-wrap: remove before/after calls in init (Trevor Norris) #1614
  • [bd42ba056a] - async-wrap: set flags using functions (Trevor Norris) #1614
  • [4b2c786449] - async-wrap: pass PROVIDER as first arg to init (Trevor Norris) #1614
  • [84bf609fd2] - async-wrap: don't call init callback unnecessarily (Trevor Norris) #1614
  • [04cc03b029] - deps: update libuv to 1.5.0 (Saúl Ibarra Corretgé) #1646
  • [b16d9c28e8] - deps: upgrade v8 to 4.2.77.20 (Ben Noordhuis) #1639
  • [9ec3109272] - doc: add TC meeting 2015-04-29 minutes (Rod Vagg) #1585
  • [2c7206254c] - doc: fix typo in readme.md (AQNOUCH Mohammed) #1643
  • [71dc7152ee] - doc: fix PR link in CHANGELOG (Brian White) #1624
  • [b97b96d05a] - install: fix NameError (thefourtheye) #1628
  • [6ccbe75384] - js_stream: fix buffer index in DoWrite (Shigeki Ohtsu) #1635
  • [c43855c49c] - src: export the ParseEncoding function on Windows (Ivan Kozik) #1596
  • [8315b22390] - src: fix pedantic cpplint whitespace warnings (Ben Noordhuis) #1640
  • [b712af79a7] - src: fix NODE_DEPRECATED macro with old compilers (Ben Noordhuis) #1626
  • [2ed10f1349] - src: fix minor inefficiency in Buffer::New() call (Ben Noordhuis) #1577
  • [f696c9efab] - src: fix deprecated use of Buffer::New() (Ben Noordhuis) #1577
  • [0c8f13df8f] - tools: remove unused GuessWordSize function (thefourtheye) #1638

@Fishrock123
Copy link
Contributor

I suspect this will be 2.1.0 due to an upcoming libuv 1.5.0 - #1621 (comment)

(which will fix a bunch of issues in our tracker)

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label May 5, 2015
@imyller
Copy link
Member

imyller commented May 5, 2015

Well, for what it's worth:

you broke my stuff!!

@rvagg
Copy link
Member Author

rvagg commented May 5, 2015

@imyller do we have issues to work on fixing for you?

@imyller
Copy link
Member

imyller commented May 5, 2015

@rvagg nothing unexpected for 2.0.0 :)

Just tracking non-core packages needing native module upgrades due to changes made in 2.0.0 at issue #1620

I'm maintaining OpenEmbedded packaging of io.js (meta-iojs). Embedded side tends to depend more on packages with native modules so 2.0.0 has larger impact there. serial ports, microtime, usb/hid, dtrace etc.

@kkoopa
Copy link

kkoopa commented May 5, 2015

Oh, you'll love io.js 3.0 in a couple of weeks then.

@silverwind
Copy link
Contributor

libuv 1.5.0 should happen momentarily, but no reason to delay this patch release.

@Fishrock123
Copy link
Contributor

Yeah, echoing @silverwind here. The io.js train is leaving the station today/tomorrow with fixes.

@Fishrock123
Copy link
Contributor

@rvagg updated the OP with a new commit list. Tomorrow sounds good, some nice fixes in here.

@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

current state of master, a few greens recently so it looks like we're getting things into shape https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/651/

also, what happened to all those windows timeouts? perhaps the libuv upgrade has helped there given that it's fixed other windows problems?

@Fishrock123
Copy link
Contributor

also, what happened to all those windows timeouts?

Idk jenkins switched to green and stuff became fine

status: Will be landing #1596 momentarily. done

@bricss
Copy link

bricss commented May 7, 2015

So, counting down for release :)

@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/652/ running that while I chase up a changelog, there's a couple of things worth expanding on in here and I don't have all the info yet. @trevnorris for the async_wrap additions in particular.

@rvagg rvagg force-pushed the v2.0.1-proposal branch from 183e16f to c427aed Compare May 7, 2015 19:47
rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

converted this issue to a pull request, see attached CHANGELOG diff for proposed release notes, PTAL

@rvagg rvagg force-pushed the v2.0.1-proposal branch from c427aed to 3e92b4e Compare May 7, 2015 19:48
rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
- [#1621](https://github.com/iojs/io.js/issues/1621) build errors associated with the bundled libuv
- [#1512](https://github.com/iojs/io.js/issues/1512) should properly fix Windows termination errors
* **addons**: the `NODE_DEPRECATED` macro was causing problems with compiling addons with older compilers, this should now be resolved (Ben Noordhuis) [#1626](https://github.com/iojs/io.js/pull/1626)
* **V8**: upgrade V8 from 4.2.77.18 to 4.2.77.20 with minor changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention here that it unbreaks the FreeBSD build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/changes/fixes/

@rvagg rvagg force-pushed the v2.0.1-proposal branch from 3e92b4e to 5346c69 Compare May 7, 2015 19:54
rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
@Fishrock123
Copy link
Contributor

converted this issue to a pull request

This is a thing??

LGTM otherwise though.

@Fishrock123
Copy link
Contributor

I don't think I've seen this CI failure before: (win2012r2) https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/652/nodes=win2012r2/tapTestReport/test.tap-709/

@rvagg rvagg force-pushed the v2.0.1-proposal branch from 5346c69 to 85c501d Compare May 7, 2015 20:03
rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

@Fishrock123 there's an API for it, use hub to interact with it

@indutny or @bnoordhuis can you shed any light on whether the test-tls-ticket-cluster.js failure @ https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/652/nodes=win2012r2/tapTestReport/test.tap-709/ might be a concern?

@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

@rvagg rvagg force-pushed the v2.0.1-proposal branch from 85c501d to 5481ce6 Compare May 7, 2015 20:08
rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
@rvagg rvagg force-pushed the v2.0.1-proposal branch from 5481ce6 to 50d5712 Compare May 7, 2015 20:10
@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

gah! test-tls-ticket-cluster.js on win2008 this time but ok on 2012, not sure what to make of this, @iojs/crypto

@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

rebooted the windows build servers, found a bunch of hung msbuild.exe processes on a 2012 and a 2008 machine

running again: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/654/

@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

only test-debug-port-from-cmdline.js failing on one windows box now, but I have bigger jenkins problems, WOE!

@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

OK, screw Jenkins, this is only impacting the Ubuntu 10.04 machines right now and is JDK related so I'm going to pretend the JVM isn't a thing that exists and move on with a release. Pushing ahead with tag and build now.

rvagg added a commit that referenced this pull request May 7, 2015
@rvagg
Copy link
Member Author

rvagg commented May 7, 2015

@rvagg rvagg closed this May 7, 2015
Starefossen pushed a commit to Starefossen/docker-iojs that referenced this pull request May 9, 2015
PR-URL: nodejs#57
Related: nodejs/node#1629

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants