Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use doc-only instead of doc #16309

Closed
wants to merge 1 commit into from
Closed

build: use doc-only instead of doc #16309

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 19, 2017

Use make doc-only instead of make doc where applicable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@Trott
build: use doc-only instead of doc
5af49dc 
Use `make doc-only` instead of `make doc` where applicable.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 19, 2017
@Trott
Copy link
Member Author

Trott commented Oct 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10844/

@joyeecheung
Copy link
Member

Raspberry Pi failure should be fixed by #16301

@Trott
Copy link
Member Author

Trott commented Oct 19, 2017

Landed in d6ba14e

@Trott Trott closed this Oct 19, 2017
Trott added a commit to Trott/io.js that referenced this pull request Oct 19, 2017
@Trott
build: use doc-only instead of doc
d6ba14e 
Use `make doc-only` instead of `make doc` where applicable.

PR-URL: nodejs#16309
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@Trott @MylesBorins
build: use doc-only instead of doc
dfaa057 
Use `make doc-only` instead of `make doc` where applicable.

PR-URL: #16309
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@Trott @addaleax
build: use doc-only instead of doc
0727916 
Use `make doc-only` instead of `make doc` where applicable.

PR-URL: nodejs/node#16309
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@Trott @addaleax
build: use doc-only instead of doc
bbff1d4 
Use `make doc-only` instead of `make doc` where applicable.

PR-URL: nodejs/node#16309
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott Trott deleted the fix-part-two branch January 13, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@hiroppy hiroppy hiroppy approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @joyeecheung @MylesBorins @tniessen @hiroppy @gireeshpunathil @nodejs-github-bot