Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak esignore #16372

Merged
merged 3 commits into from
Oct 26, 2017
Merged

Tweak esignore #16372

merged 3 commits into from
Oct 26, 2017

Commits on Oct 26, 2017

  1. tools: no trailing slash in ignore patterns 

    Makes eslint exclude directories without enumerating their content

PR-URL: nodejs#16372
Refs: nodejs#16010
Refs: nodejs#16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @refack
    refack committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    748f5d8 View commit details
    Browse the repository at this point in the history

  2. test: change tmp directories prefix 

    `.tmp` prefix allows easier exclusion

PR-URL: nodejs#16372
Refs: nodejs#16010
Refs: nodejs#16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @refack
    refack committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    2be9198 View commit details
    Browse the repository at this point in the history

  3. build: improve make clean 

    also undocument the `vcbuild.bat` command since it's broken
and seems to only be relevant to release builds

PR-URL: nodejs#16372
Refs: nodejs#16010
Refs: nodejs#16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @refack
    refack committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    9ab6481 View commit details
    Browse the repository at this point in the history