Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: custom priority for push streams #16444

Closed
wants to merge 2 commits into from
Closed

http2: custom priority for push streams #16444

wants to merge 2 commits into from

Commits on Oct 24, 2017

  1. http2: custom priority for push streams 

    Sets the priority silently on push streams. Previously the weight options, whilst documented, was simply ignored.

Note that the client is not informed of the non-default priority. The nghttp2 library ignores push stream flags (e.g. 0x20 for priority). It also currently offers no way to set priority value during push stream creation. This appears to be by design, as discussed here:
- nghttp2/nghttp2#429
- nghttp2/nghttp2#430
    @sebdeckers
    sebdeckers committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    50d3088 View commit details
    Browse the repository at this point in the history

  2. explicit checking of silent priority (squash)

    @sebdeckers
    sebdeckers committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    d5f100d View commit details
    Browse the repository at this point in the history