http2: remove non-existent pushStream weight option #16451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2.
nodejs-github-bot
added
doc
|
I take this is an alternative to #16444? Because depending on whether we keep the change to core or not, we might want to keep the documented The explicit note: re push streams is good though but I think it could maybe mention that 'not allowed' refers to the HTTP/2 spec as opposed to Node, since it won't throw or anything if they do that. (Will approve once we have clarity re: the weight option since I'm not clear whether we're keeping it or not.) |
jasnell
approved these changes
Oct 24, 2017
cjihrig
approved these changes
Oct 24, 2017
4 tasks
apapirovski
approved these changes
Oct 25, 2017
|
Landed in a0f7ae6 |
apapirovski
pushed a commit
that referenced
this pull request
Oct 27, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: #16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: #16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: #16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: #16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: nodejs/node#16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: nodejs/node#16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: nodejs/node#16451 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server.
Documents the recommended approach to set a silent priority as used internally by nghttp2.
Alternative to #16444
Checklist
Affected core subsystem(s)
http2