crypto: migrate CipherBase to internal/errors #16527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
crypto
nodejs-github-bot
added
c++
|
ping @nodejs/tsc |
benjamingr
approved these changes
Oct 26, 2017
apapirovski
approved these changes
Oct 26, 2017
|
CI is good. |
jasnell
force-pushed
the
migrate-cipherbase-internal-errors
branch
from
d314326 to
bd0ddad
Compare
joyeecheung
reviewed
Oct 28, 2017
src/node_crypto.cc
Outdated
| CipherBase* cipher; | ||
| ASSIGN_OR_RETURN_UNWRAP(&cipher, args.Holder()); | ||
|
|
||
| if (!cipher->initialised_ || | ||
| !cipher->IsAuthenticatedMode() || | ||
| cipher->kind_ != kDecipher) { | ||
| return env->ThrowError("Attempting to set auth tag in unsupported state"); | ||
| return args.GetReturnValue().Set(true); |
There was a problem hiding this comment.
Any reason this is inconsistent with #16529 (which return false on error?)
There was a problem hiding this comment.
good catch. no particular reason, just didn't remember ;-) I'll change this to false
jasnell
force-pushed
the
migrate-cipherbase-internal-errors
branch
from
bd0ddad to
40d144e
Compare
Migrates most of CipherBase errors to use internal/errors. There are still a handful remaining that need to be handled separately
jasnell
force-pushed
the
migrate-cipherbase-internal-errors
branch
from
40d144e to
acd2d94
Compare
|
@joyeecheung ... PTAL |
joyeecheung
approved these changes
Oct 30, 2017
jasnell
added a commit
that referenced
this pull request
Oct 30, 2017
Migrates most of CipherBase errors to use internal/errors. There are still a handful remaining that need to be handled separately PR-URL: #16527 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in e567402 |
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Migrates most of CipherBase errors to use internal/errors. There are still a handful remaining that need to be handled separately PR-URL: nodejs/node#16527 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Migrates most of CipherBase errors to use internal/errors. There are still a handful remaining that need to be handled separately PR-URL: nodejs/node#16527 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates most of CipherBase errors to use internal/errors.
There are still a handful remaining that need to be handled
separately
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto