Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: show lexically scoped vars in tab completion #16591

Closed
wants to merge 2 commits into from

Commits on Dec 21, 2017

  1. deps: cherry-pick 50f7455 from upstream V8

    Original commit message:
    
        [inspector] added Runtime.globalLexicalScopeNames method
    
        The method returns names for all available top-level scope variables
        in giving context.
    
        R=dgozman@chromium.org,jgruber@chromium.org
    
        Bug: chromium:681333
        Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
        Change-Id: I2d0b600e1afbfef9087f53ea9c26abe1e112047c
        Reviewed-on: https://chromium-review.googlesource.com/719409
        Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
        Cr-Commit-Position: refs/heads/master@{nodejs#48618}
    
    Refs: v8/v8@50f7455
    
    PR-URL: nodejs#16591
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    993253d View commit details
    Browse the repository at this point in the history
  2. repl: show lexically scoped vars in tab completion

    Use the V8 inspector protocol, if available, to query the list of
    lexically scoped variables (defined with `let`, `const` or `class`).
    
    PR-URL: nodejs#16591
    Fixes: nodejs#983
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    cfd2a99 View commit details
    Browse the repository at this point in the history