Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: refactor settings handling #16668

Closed
wants to merge 1 commit into from
Closed

http2: refactor settings handling #16668

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 1, 2017

Add Http2Seettings utility class for handling settings logic and reducing code duplication.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 1, 2017
sebdeckers
sebdeckers approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@sebdeckers sebdeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is above my pay grade, but LGTM. 😜

@mscdex mscdex added http2 Issues or PRs related to the http2 subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 1, 2017
apapirovski
apapirovski reviewed Nov 1, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

XadillaX
XadillaX approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasnell
Copy link
Member Author

jasnell commented Nov 2, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11139/

mcollina
mcollina approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
http2: refactor settings handling
18b3123 
Add `Http2Seettings` utility class for handling settings
logic and reducing code duplication.
jasnell added a commit that referenced this pull request Nov 3, 2017
@jasnell
http2: refactor settings handling
de24602 
Add `Http2Seettings` utility class for handling settings
logic and reducing code duplication.

PR-URL: #16668
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Nov 3, 2017

Landed in de24602

@jasnell jasnell closed this Nov 3, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@jasnell @cjihrig
http2: refactor settings handling
dfe5684 
Add `Http2Seettings` utility class for handling settings
logic and reducing code duplication.

PR-URL: nodejs#16668
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
gibfahn pushed a commit that referenced this pull request Nov 14, 2017
@jasnell @gibfahn
http2: refactor settings handling
8cf8a32 
Add `Http2Seettings` utility class for handling settings
logic and reducing code duplication.

PR-URL: #16668
Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XadillaX XadillaX XadillaX approved these changes

@sebdeckers sebdeckers sebdeckers approved these changes

@mcollina mcollina mcollina approved these changes

@apapirovski apapirovski apapirovski approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jasnell @apapirovski @mcollina @sebdeckers @XadillaX @mscdex @MylesBorins @gibfahn @nodejs-github-bot