build: add a OFFLINE var to Makefile

[danbev]

We have a build environment that restricts our internet connection and
currently building fails due to the lint-md target needs to be able to
install npm modules.

This commit suggests adding a OFFLINE variable to the Makefile which
can be used like in the following examples:

$ env OFFLINE=true make -j8 test

$ make -j8 test OFFLINE=true

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

build

[gibfahn]

All the other flags in the Makefile appear to be ALL_CAPS, so for consistency, how about OFFLINE=true?

General idea seems like a good idea to me though.

Putting a line at the top would probably be good for visibility too.

node/Makefile

Lines 3 to 16 in 841e305

	BUILDTYPE ?= Release
	PYTHON ?= python
	DESTDIR ?=
	SIGN ?=
	PREFIX ?= /usr/local
	FLAKY_TESTS ?= run
	TEST_CI_ARGS ?=
	STAGINGSERVER ?= node-www
	LOGLEVEL ?= silent
	OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
	COVTESTS ?= test-cov
	GTEST_FILTER ?= "*"
	GNUMAKEFLAGS += --no-print-directory
	GCOV ?= gcov

cc/ @nodejs/build

[gibfahn]

Out of interest how do you get node onto your machines? Seems like the ideal solution would be to have a git clone && make fetch-all or something, that downloads everything you need. Allows us to keep the git repo smaller, but still make it easy for people to download everything.

[danbev]

All the other flags in the Makefile appear to be ALL_CAPS, so for consistency, how about OFFLINE=true?

Yeah that makes sense and I like OFFLINE which sounds much better. I'll update, thanks!

Out of interest how do you get node onto your machines?

It is placed on the machine by an internal system that packages node as a tar.gz file.

[gibfahn]

It is placed on the machine by an internal system that packages node as a tar.gz file.

So it does a git clone then tars it up? In that case a make fetch-all type command would solve the issue for you right?

[danbev]

So it does a git clone then tars it up? In that case a make fetch-all type command would solve the issue for you right?

The machine that does this is internal and has the same restrictions I'm afraid.

[gibfahn]

The machine that does this is internal and has the same restrictions I'm afraid.

So is there a firewall exception for https://github.com/nodejs/node ?

[danbev]

So is there a firewall exception for https://github.com/nodejs/node ?

I don't know how it is configured, but there is no way to access anything external to this environment, github or anything else.

[richardlau]

I think #16635 will stop the lint-md target from needing to install modules (since they'll be there already in the source tree).

[danbev]

I think #16635 will stop the lint-md target from needing to install modules (since they'll be there already in the source tree).

Nice, I was not aware of that. Thanks @gibfahn for feedback on this. I'll close this once #16635 lands.

[joyeecheung]

By the way, does that build machine need to build docs and run linters? If not, then it can just do make test-only, which only build the binary and run the tests.

[danbev]

By the way, does that build machine need to build docs and run linters?

Thanks for the suggestion but we also have to build the docs, but running the linters would be alright to skip.

[danbev]

Closing as this PR is out of date.