Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two compiler warnings #16726

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Fix two compiler warnings #16726

merged 2 commits into from
Nov 7, 2017

Conversation

bnoordhuis
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 3, 2017
mhdawson
mhdawson approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoordhuis
src: fix -Winconsistent-missing-override warning
9087a1d 
Fix a compiler warning that was introduced in commit 4db1bc8
("http2: allocate on every chunk send") by adding an `override` keyword.

PR-URL: nodejs#16726
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@bnoordhuis
src: fix -Wunused-result warning
02bad59 
Fix a compiler warning that was introduced in commit c3dc0e0
("src: add CollectExceptionInfo & errors.SystemError") by adding
a `.FromJust()` call.

PR-URL: nodejs#16726
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@bnoordhuis bnoordhuis force-pushed the fix-compiler-warnings branch from 0015fd8 to 02bad59 Compare November 7, 2017 11:12
@bnoordhuis bnoordhuis closed this Nov 7, 2017
@bnoordhuis bnoordhuis deleted the fix-compiler-warnings branch November 7, 2017 11:13
@bnoordhuis bnoordhuis merged commit 02bad59 into nodejs:master Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@bnoordhuis @cjihrig
src: fix -Winconsistent-missing-override warning
da66610 
Fix a compiler warning that was introduced in commit 4db1bc8
("http2: allocate on every chunk send") by adding an `override` keyword.

PR-URL: nodejs#16726
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MylesBorins pushed a commit that referenced this pull request Dec 7, 2017
@bnoordhuis @MylesBorins
src: fix -Winconsistent-missing-override warning
73c2bb5 
Fix a compiler warning that was introduced in commit 4db1bc8
("http2: allocate on every chunk send") by adding an `override` keyword.

PR-URL: #16726
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 8, 2017
@bnoordhuis @MylesBorins
src: fix -Winconsistent-missing-override warning
8e8fac2 
Fix a compiler warning that was introduced in commit 4db1bc8
("http2: allocate on every chunk send") by adding an `override` keyword.

PR-URL: #16726
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins
Copy link
Contributor

02bad59 did not land on v9.x as it touches Semver-Major code. Marking this as backported to 9.x as only 1 of 2 commits landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@fhinkel fhinkel fhinkel approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bnoordhuis @MylesBorins @apapirovski @fhinkel @danbev @jasnell @targos @cjihrig @mhdawson @nodejs-github-bot