Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix json generator warnings #16742

Closed
wants to merge 1 commit into from
Closed

doc: fix json generator warnings #16742

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 4, 2017

Fixes the following warnings:

Warning: invalid param "label "
 > {"textRaw":"`label` {string} The display label for the counter. Defaults to `'default'`. ","name":"label","type":"string","desc":"The display label for the counter. Defaults to `'default'`."}
 > console.countReset([label = 'default'])
Warning: invalid param "...label"
 > {"textRaw":"`label` {any} ","name":"label","type":"any"}
 > console.group([...label])
Warning: invalid param "label "
 > {"textRaw":"`label` {string} The display label for the counter. Defaults to `'default'`. ","name":"label","type":"string","desc":"The display label for the counter. Defaults to `'default'`."}
 > console.countReset([label = 'default'])
Warning: invalid param "...label"
 > {"textRaw":"`label` {any} ","name":"label","type":"any"}
 > console.group([...label])
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@lpinca
doc: fix json generator warnings
bc826e2 
- Fix `console.countReset()` signature
- Fix `console.group()` arguments list
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Nov 4, 2017
@lpinca
Copy link
Member Author

lpinca commented Nov 7, 2017

Landed in 137c780.

@lpinca lpinca closed this Nov 7, 2017
lpinca added a commit that referenced this pull request Nov 7, 2017
@lpinca
doc: fix json generator warnings
137c780 
- Fix `console.countReset()` signature
- Fix `console.group()` arguments list

PR-URL: #16742
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca deleted the fix/json-generator-warnings branch November 7, 2017 08:49
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@lpinca @cjihrig
doc: fix json generator warnings
6739f41 
- Fix `console.countReset()` signature
- Fix `console.group()` arguments list

PR-URL: nodejs#16742
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@lpinca @MylesBorins
doc: fix json generator warnings
f2a9c02 
- Fix `console.countReset()` signature
- Fix `console.group()` arguments list

PR-URL: #16742
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @apapirovski @danbev @jasnell @cjihrig @tniessen @gireeshpunathil @MylesBorins @nodejs-github-bot