-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change common with fixtures as task of nodetodo #16809
Conversation
@DeltaLikeM - looks like you pushed changed without:
on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again? |
test/parallel/test-repl.js
Outdated
@@ -40,7 +41,7 @@ let server_tcp, server_unix, client_tcp, client_unix, replServer; | |||
|
|||
|
|||
// absolute path to test/fixtures/a.js | |||
const moduleFilename = require('path').join(common.fixturesDir, 'a'); | |||
const moduleFilename = require('path').join(fixtures.fixturesDir, 'a'); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be:
const moduleFilename = fixtures.path('a');
f7fa5cd
to
ec8d9ca
Compare
Beware: Commit author is not associated with the GitHub account. @DeltaLikeM Can you add the local email to your GitHub account email list? See the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
test/parallel/test-repl.js
Outdated
@@ -21,6 +21,7 @@ | |||
|
|||
'use strict'; | |||
const common = require('../common'); | |||
const fixtures = require('../common/fixtures') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A linter nit: missing semicolon.
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Landed in ac1e6bd , thanks! |
PR-URL: nodejs#16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16809 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)