Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a test description for test/parallel/test-cluster-fork-env.js #16833

Closed
wants to merge 3 commits into from
Closed

test: add a test description for test/parallel/test-cluster-fork-env.js #16833

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdf8097
test: add value to assertion message
grantgasp Nov 6, 2017
e3a4af5
test: fix to assert message
grantgasp Nov 7, 2017
4ef455a
test: add test description
grantgasp Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/parallel/test-cluster-fork-env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,12 @@ if (cluster.isWorker) {
});

process.once('exit', function() {
assert.ok(checks.using, 'The worker did not receive the correct env.');
assert.ok(checks.using, 'The worker did not receive the correct env.' +
`${checks.using}`);
assert.ok(
checks.overwrite,
'The custom environment did not overwrite the existing environment.');
'The custom environment did not overwrite the existing environment.' +
`${checks.overwrite}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we are lacking spaces here and using unnecessary concatenation and redundant templates. What if we use something like this?

    assert.ok(
      checks.using,
      `The worker did not receive the correct env. ${checks.using}`);
    assert.ok(
      checks.overwrite,
      `The custom environment did not overwrite the existing environment. ${
        checks.overwrite}`);

});

}