tools: make eslint work on subdirectories #1686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is included in my repl PR as well. |
|
@chrisdickinson yep, please manually lint it until this is landed. |
|
@silverwind Ah, I mean, these changes are literally included in my PR :) |
|
I can rebase once this lands, though. LGTM. |
silverwind
added a commit
that referenced
this pull request
May 12, 2015
The old pattern didn't include files in lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well. PR-URL: #1686 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
Thanks, landed in c58264e |
|
AH, Thanks @silverwind ! |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
The old pattern didn't include files in lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well. PR-URL: nodejs#1686 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old pattern didn't include files in
lib/internal. This changes the pattern to directories which makes eslint apply to all subdirectories as well.related: #1685
cc: @yosuke-furukawa