WIP? tools: add update-dep.sh #1688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if [ -z $git_ref ]; then | ||
| echo "Unusable git state. Please checkout a branch." >&2 | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
Hmm, this doesn't appear to actually catch when $git_ref is empty..
|
I'm going to decline reviewing this because I don't have a need for it myself. |
|
In general, I'm not a big fan of a tool like this but since I wouldn't use it I don't have a strong opinion. My approach would be to improve documentation about bumping packages (collecting floating patches, applying, verifying, etc). |
|
@chrisdickinson you had a bunch of comments on the original thread, thoughts on this? |
|
@chrisdickinson (irc):
Going to just close this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working, but possibly rough implementation of a dependency upgrade tool as discussed around #1419.
In particular, I don't feel confident at all about stgit. it works, but it leaves a mess and doesn't work if you try to do the same upgrade twice without manually resetting stgit.
This can't do c-ares (yet?) and doesn't touch v8 because v8 requires a whole world of other things that may be more suitable for it's own tool.
R=@othiym23 / @rvagg / @chrisdickinson / @bnoordhuis