Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in http2 doc #16993

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in http2 doc #16993

wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Nov 13, 2017

Sesssion -> Session

Checklist
Affected core subsystem(s)

@devsnek
doc: fix typo in http2 doc
c1c6a60 
`Sesssion` -> `Session`
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Nov 13, 2017
jasnell
jasnell approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't have to wait longer to land

jasnell pushed a commit that referenced this pull request Nov 13, 2017
@devsnek @jasnell
doc: fix typo in http2 doc
29de91b 
`Sesssion` -> `Session`

PR-URL: #16993
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 13, 2017

Landed in 29de91b

@jasnell jasnell closed this Nov 13, 2017
evanlucas pushed a commit that referenced this pull request Nov 14, 2017
@devsnek @evanlucas
doc: fix typo in http2 doc
62a6bc0 
`Sesssion` -> `Session`

PR-URL: #16993
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@devsnek @MylesBorins
doc: fix typo in http2 doc
891ddad 
`Sesssion` -> `Session`

PR-URL: #16993
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
@devsnek devsnek deleted the patch-2 branch March 31, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@devsnek @jasnell @apapirovski @lpinca @cjihrig @gireeshpunathil @MylesBorins @nodejs-github-bot