Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix compiler warning from SetAccessor #17009

Closed
wants to merge 1 commit into from
Closed

src: fix compiler warning from SetAccessor #17009

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 14, 2017

Currently the following compiler warning is displayed when building:

../src/node.cc:3270:12: warning: 'SetAccessor' is deprecated
[-Wdeprecated-declarations]
  process->SetAccessor(FIXED_ONE_BYTE_STRING(env->isolate(), "ppid"),
           ^
../deps/v8/include/v8.h:3184:22: note: 'SetAccessor' has been
explicitly marked deprecated here
                bool SetAccessor(Local<Name> name,

This commit updates the call to use the Maybe version.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: fix compiler warning from SetAccessor
9d1b178 
Currently the following compiler warning is displayed when building:
../src/node.cc:3270:12: warning: 'SetAccessor' is deprecated
[-Wdeprecated-declarations]
  process->SetAccessor(FIXED_ONE_BYTE_STRING(env->isolate(), "ppid"),
           ^
../deps/v8/include/v8.h:3184:22: note: 'SetAccessor' has been
explicitly marked deprecated here
                bool SetAccessor(Local<Name> name,

This commit updates the call to use the Maybe<bool> version.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 14, 2017
@danbev
Copy link
Contributor Author

danbev commented Nov 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11412/

@TimothyGu
Copy link
Member

Duplicate of #16958 and #16966.

@danbev
Copy link
Contributor Author

danbev commented Nov 14, 2017

Closed as it is a duplicate.

@danbev danbev closed this Nov 14, 2017
@danbev danbev deleted the setaccessor-deprecated-warning branch November 16, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbev @TimothyGu @nodejs-github-bot