Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add missing include in node_platform.h #17133

Closed
wants to merge 1 commit into from
Closed

src: add missing include in node_platform.h #17133

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #17083

I will fast-track this to un-break CI.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/node_platform

@fhinkel

@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 19, 2017
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 19, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/14142/

@addaleax
Copy link
Member Author

Landed in d61cd9d

@addaleax addaleax closed this Nov 19, 2017
@addaleax addaleax deleted the platform-include branch November 19, 2017 13:21
addaleax added a commit that referenced this pull request Nov 19, 2017
@addaleax
src: add missing include in node_platform.h
d61cd9d 
PR-URL: #17133
Refs: #17083
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@fhinkel
Copy link
Member

fhinkel commented Nov 19, 2017

Thank you 🙏

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@addaleax @MylesBorins
src: add missing include in node_platform.h
e900090 
PR-URL: #17133
Refs: #17083
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@gibfahn gibfahn mentioned this pull request Dec 19, 2017
Closed
2 tasks
@gibfahn
Copy link
Member

gibfahn commented Jan 27, 2018

Should come with #17083 if that gets backported to v8.x.

@MylesBorins MylesBorins mentioned this pull request May 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @fhinkel @gibfahn @apapirovski @MylesBorins @nodejs-github-bot