Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update test-http-parser-free to use countdown timer #17322

Closed
wants to merge 3 commits into from
Closed

test: Update test-http-parser-free to use countdown timer #17322

wants to merge 3 commits into from

Conversation

daxlab
Copy link
Contributor

@daxlab daxlab commented Nov 26, 2017 •
edited
Loading

Fixes: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 26, 2017
maclover7
maclover7 approved these changes Nov 26, 2017
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

test/parallel/test-http-parser-free.js Outdated
if (++responses === N) {
server.close();
}
countdown.dec();
res.resume();
});
})(i);
}
});

process.on('exit', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this check? Doesn't server.close() / end of execution from the Countdown mean we've already hit zero remaining?

cc @jasnell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the process.on('exit') can be removed.

jasnell
jasnell approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the process.on('exit') handler removed.

@daxlab
Copy link
Contributor Author

daxlab commented Nov 26, 2017

LGTM with the process.on('exit') handler removed.

Done.

@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11730/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2017
@addaleax
Copy link
Member

Landed in 6d1f8a3

@addaleax addaleax closed this Nov 28, 2017
addaleax pushed a commit that referenced this pull request Nov 28, 2017
@daxlab @addaleax
test: Update test-http-parser-free to use countdown timer
6d1f8a3 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@daxlab daxlab deleted the test-http-parser-free branch November 28, 2017 04:53
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: Update test-http-parser-free to use countdown timer
a7455f7 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: Update test-http-parser-free to use countdown timer
7a68fda 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: Update test-http-parser-free to use countdown timer
b033d38 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@daxlab @gibfahn
test: Update test-http-parser-free to use countdown timer
f3c1158 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@daxlab @gibfahn
test: Update test-http-parser-free to use countdown timer
80d1671 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@daxlab @gibfahn
test: Update test-http-parser-free to use countdown timer
74d5e6b 
PR-URL: #17322
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclover7 maclover7 maclover7 approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracking issue] Converting tests to use Countdown
7 participants
@daxlab @jasnell @addaleax @maclover7 @mscdex @gibfahn @nodejs-github-bot