Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update test-http-client-agent to use countdown timer #17325

Closed
wants to merge 1 commit into from
Closed

test: Update test-http-client-agent to use countdown timer #17325

wants to merge 1 commit into from

Conversation

daxlab
Copy link
Contributor

@daxlab daxlab commented Nov 26, 2017

Fixes: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 26, 2017
@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11733/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@addaleax
Copy link
Member

Landed in 3996da6

@addaleax addaleax closed this Nov 28, 2017
addaleax pushed a commit that referenced this pull request Nov 28, 2017
@daxlab @addaleax
test: Update test-http-client-agent to use countdown timer
3996da6 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@daxlab daxlab deleted the test-http-client-agent branch November 28, 2017 04:53
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: Update test-http-client-agent to use countdown timer
7f8f607 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: Update test-http-client-agent to use countdown timer
4095242 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@daxlab @MylesBorins
test: Update test-http-client-agent to use countdown timer
4a749c3 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@daxlab @gibfahn
test: Update test-http-client-agent to use countdown timer
956198f 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@daxlab @gibfahn
test: Update test-http-client-agent to use countdown timer
4f0cdae 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@daxlab @gibfahn
test: Update test-http-client-agent to use countdown timer
6137afa 
PR-URL: #17325
Refs: #17169
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@maclover7 maclover7 maclover7 approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracking issue] Converting tests to use Countdown
7 participants
@daxlab @maclover7 @addaleax @jasnell @mscdex @gibfahn @nodejs-github-bot