tools: don't create package-lock.json

[refack]

An alternative attempt to minimize possible noise from running make lint-md-build

Refs: #17320

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

tools

[refack]

/CC @nodejs/build

[gibfahn]

Does this undo the benefit of adding the package-lock.json in the first place?

[refack]

Does this undo the benefit of adding the package-lock.json in the first place?

Good question. I would think not, but I'll check.

[gibfahn]

I assumed it would due to the docs:

The --no-shrinkwrap argument, which will ignore an available package lock or shrinkwrap file and use the package.json instead.

[refack]

@gibfahn yes, that was not the right way. From what I learned now this is what npm-shrinkwrap.json is for. It is only created if requested explicitly, and has the same validation & performance benefits.

From CI https://ci.nodejs.org/job/node-test-linter/13943/console:

18:11:36 HEAD is now at da550abe6e... tools: use shrinkwrap instead of package-lock
...
18:11:38 + gmake lint-md-build
18:11:38 Markdown linter: installing remark-cli into tools/
18:11:45 added 155 packages in 4.976s
18:11:45 Markdown linter: installing remark-preset-lint-node into tools/
18:11:48 added 48 packages in 2.29s

[joyeecheung]

There is also a package-lock.json in tools/doc..

[refack]

ack.
renamed.

[refack]

@addaleax I've added a commit that fixes the inconsistency in tools/doc/package.json

[addaleax]

@refack I still think #17320 is the way to go here, tbh

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/3/

As I commented in #17320 (comment), landing this does not preclude adding the dependencies later.

[BridgeAR]

@refack I am not sure why you added the ready label even though there is no LG at all?

@addaleax do you want to make your concerns explicit?

[addaleax]

@BridgeAR I’m good here… but yes, no approvers yet and I would still prefer the in-tree approach.

[BridgeAR]

@nodejs/tsc can you please have a look to decide what to do?

[BridgeAR]

@nodejs/collaborators PTAL.

[BridgeAR]

@refack would you be so kind and rebase this? :-)

[mcollina]

LGTM

[BridgeAR]

@refack if I am not mistaken, a better alternative is #20109 and this should likely be closed?

[BridgeAR]

Ping @refack

[Trott]

I'm going to remove the tsc-review label on this one. @BridgeAR added it but indicated in a comment at a later date that a better alternative (also authored by @refack) appeared. Please feel free to re-add tsc-review if appropriate.

[BridgeAR]

I am closing this due to no response. @refack please feel free to reopen in case you want to continue working on this.

[refack]

Hello from jenkins

[refack]

test this please

[ryzokuken]

@refack what's the status of this? Are you still working on it?

[maclover7]

ping @refack?

[refack]

Made mostly obsolete by #22399 and others