Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: 'constructor' implies use of new keyword #17364

Closed
wants to merge 3 commits into from
Closed

doc: 'constructor' implies use of new keyword #17364

wants to merge 3 commits into from

Commits on Nov 28, 2017

  1. doc: 'constructor' implies use of new keyword 

    the square module is described as exporting a constructor,
which would mean it would need to be invoked with the
new keyword in bar.js after requiring it. Otherwise it's
technically a factory function, not a constructor.
    @CameronMoorehead
    CameronMoorehead authored Nov 28, 2017
    Configuration menu
    Copy the full SHA
    96c9f1d View commit details
    Browse the repository at this point in the history

  2. doc: square constructor name capitalized to Square

    @CameronMoorehead
    CameronMoorehead authored Nov 28, 2017
    Configuration menu
    Copy the full SHA
    acc507f View commit details
    Browse the repository at this point in the history

  3. doc: my Square to mySquare

    @CameronMoorehead
    CameronMoorehead authored Nov 28, 2017
    Configuration menu
    Copy the full SHA
    fb9af62 View commit details
    Browse the repository at this point in the history