buffer: add readInt64BE, readInt64LE, readUInt64BE, and readUInt64LE

TooTallNate committed May 23, 2015

buffer: add writeInt64BE, writeInt64LE, writeUInt64BE, and writeUInt64LE

TooTallNate committed May 23, 2015

buffer: add address() function

TooTallNate committed May 23, 2015

buffer: add 0-length NULL pointer Buffer to exports …

Seems useful to add for completeness-sake. Presumably
useful for i.e. writing the null terminator to a
null-terminated C array.

TooTallNate committed May 23, 2015

buffer: add the hex address to the inspect() output

TooTallNate committed May 23, 2015

buffer: add isNull() function

TooTallNate committed May 23, 2015

buffer: remove "base" variable name from template

TooTallNate committed May 23, 2015

buffer: return the int64 write binding values

TooTallNate committed May 23, 2015

buffer: add readPointerLE and readPointerBE

TooTallNate committed May 23, 2015

buffer: add writePointerLE and writePointerBE

TooTallNate committed May 23, 2015

buffer: use uintptr_t for address()

TooTallNate committed May 23, 2015

buffer: fix JS_MAX_INT and JS_MIN_INT values

TooTallNate committed May 23, 2015

buffer: add HasInstance check to IsNull()

TooTallNate committed May 23, 2015

buffer: add HasInstance check to Address()

TooTallNate committed May 23, 2015

buffer: allow offset to be passed to isNull and address

TooTallNate committed May 23, 2015

buffer: fix offset checking logic

TooTallNate committed May 23, 2015

buffer: inline WrapNullPointer

TooTallNate committed May 23, 2015

buffer: use nullptr

TooTallNate committed May 23, 2015

buffer: asterisks lean to the left

TooTallNate committed May 23, 2015

buffer: remove unnecessary #defines

TooTallNate committed May 23, 2015

buffer: fix most of the cpplint errors

TooTallNate committed May 23, 2015

buffer: remove EscapableHandleScope in readPointer

TooTallNate committed May 23, 2015

buffer: add CHECK calls

TooTallNate committed May 23, 2015

buffer: remove variable redefinition

TooTallNate committed May 23, 2015

buffer: use node::Utf8Value

TooTallNate committed May 23, 2015

buffer: don't use C++ streams, use printf %lx

TooTallNate committed May 23, 2015

buffer: don't rely on snprintf return value

TooTallNate committed May 23, 2015

test: fix tests for new Buffer#inspect() behavior

TooTallNate committed May 23, 2015

doc: add docs for Buffer read/writePointer

TooTallNate committed May 23, 2015

doc: buffer docs tweaks

TooTallNate committed May 23, 2015

doc: add Buffer readInt64* docs

TooTallNate committed May 23, 2015

doc: add fake memory addresses to old examples

TooTallNate committed May 23, 2015

buffer: return null from readPointer upon NULL

TooTallNate committed May 23, 2015

buffer: remove static buffer.NULL Buffer …

Should no longer be necessary now that readPointer()
returns `null` explictly.

TooTallNate committed May 23, 2015

doc: document Buffer#readPointer null behavior

TooTallNate committed May 23, 2015

buffer: remove Buffer#isNull() …

Should no longer be necessary now that readPointer*()
returns JS `null` explicitly.

TooTallNate committed May 23, 2015

buffer: remove offset param from address() …

Would make the function simply return `true` for any value >= 1,
so doesn't really make any sense to keep it around.

TooTallNate committed May 23, 2015

doc: fix buffer typo

TooTallNate committed May 23, 2015

buffer: fix checkPointer when null is passed in

TooTallNate committed May 23, 2015

doc: add Buffer#address() docs

TooTallNate committed May 23, 2015

doc: fix Buffer#address() output in example

TooTallNate committed May 23, 2015

doc: add Buffer writeInt64*() docs

TooTallNate committed May 23, 2015

Revert "doc: add fake memory addresses to old examples" …

This reverts commit 2221318.

TooTallNate committed May 23, 2015

doc: add fake memory addresses to old examples …

Properly this time…

TooTallNate committed May 23, 2015

doc: add another fake memory address to example

TooTallNate committed May 23, 2015

test: add Buffer#address() test case

TooTallNate committed May 23, 2015

test: add Buffer int64 read/write tests …

Mostly copied and refactored from the `ref` tests.

TooTallNate committed May 23, 2015

test: add writeInt64 TypeError bad input tests

TooTallNate committed May 23, 2015

test: add Buffer read/writePointer test cases

TooTallNate committed May 23, 2015

buffer: use memcpy instead of reinterpret_cast …

To avoid aliasing.

@bnoordhuis I believe this is what you meant in:
nodejs#1750 (comment)

The `test/parallel/test-buffer-pointer.js` test still passes
after this patch, so apparently it's working correctly.

TooTallNate committed May 23, 2015

buffer: use MDN links for max/min JS int values

TooTallNate committed Jun 1, 2015

buffer: do not free() buffers from readPointer*()

TooTallNate committed Jun 1, 2015

doc: remove backticks from code examples

TooTallNate committed Jun 1, 2015

buffer: remove __STDC_FORMAT_MACROS …

Ben says it's not necessary.

TooTallNate committed Jun 1, 2015

buffer: revert unnecessary whitespace fix

TooTallNate committed Jun 1, 2015

buffer: add instanceof check to address()

TooTallNate committed Jun 1, 2015

buffer: remove "pointer" functions …

These will be moved to static functions in the `ffi` module,
to remind users of their unsafe nature on the API level.

TooTallNate committed Jun 4, 2015

buffer: revert unnecessary whitespace change

TooTallNate committed Jun 4, 2015

buffer: use base of 10 for the strto(u)ll calls …

Less room for computer error this way

TooTallNate committed Jun 4, 2015

buffer: change C++-land throw to a CHECK() …

We're already checking for typeof "string"/"number" in
JS-land. No need for the extra conditional logic.

TooTallNate committed Jun 4, 2015

buffer: make strto(u)ll usage cross-platform …

The errno EINVAL behavior is a BSDism, and won't work
cross platform. Instead, pass in the char* endptr value
and check where it ended up.

TooTallNate committed Jun 5, 2015