Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: fix error emit handling #17588

Closed
wants to merge 4 commits into from
Closed

domain: fix error emit handling #17588

wants to merge 4 commits into from

Commits on Dec 10, 2017

  1. domain: fix error emit handling 

    Fix an issue where error is never emitted on the original EventEmitter
in situations where a listener for error does exist.

Refactor to eliminate unnecessary try/catch/finally block.
    @apapirovski
    apapirovski committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    e4e4e0a View commit details
    Browse the repository at this point in the history

  2. fixup: use listenerCount instead of _events

    @apapirovski
    apapirovski committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    d46e020 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. fixup: rename doError variable

    @apapirovski
    apapirovski committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    f8361f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. fixup: remove unnecessary null check

    @apapirovski
    apapirovski committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    f401c32 View commit details
    Browse the repository at this point in the history