test: remove unused disposed_ variable #17628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently building test_inspector_socket.cc generates the following
warning:
../test/cctest/test_inspector_socket.cc:189:8: warning:
private field 'disposed_' is not used [-Wunused-private-field]
bool disposed_ = false;
^
1 warning generated.
This commit removes this variable.
nodejs-github-bot
added
dont-land-on-v4.x
inspector
evanlucas
approved these changes
Dec 12, 2017
cjihrig
approved these changes
Dec 12, 2017
maclover7
approved these changes
Dec 12, 2017
BridgeAR
approved these changes
Dec 12, 2017
BridgeAR
added
fast-track
jasnell
approved these changes
Dec 12, 2017
test/aix failure looks unrelatednot ok 795 parallel/test-http-pipeline-flood
---
duration_ms: 2.673
severity: fail
stack: |-
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:497:10)
at Server.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-http-pipeline-flood.js:59:35)
at Object.onceWrapper (events.js:218:13)
at Server.emit (events.js:126:13)
at emitListeningNT (net.js:1397:10)
at process._tickCallback (internal/process/next_tick.js:152:19)
at Function.Module.runMain (module.js:703:11)
at startup (bootstrap_node.js:195:16)
at bootstrap_node.js:646:3
...test/arm-fanned failure looks unrelatedcollect2: error: ld returned 1 exit status
make[2]: *** [/home/iojs/build/workspace/node-cross-compile/out/Release/mksnapshot] Error 1
make[2]: *** Waiting for unfinished jobs....
rm ef664a04cb2935d4a7884f858a2443c912d9371a.intermediate
make[2]: Leaving directory `/home/iojs/build/workspace/node-cross-compile/out'
make[1]: *** [node] Error 2
make[1]: Leaving directory `/home/iojs/build/workspace/node-cross-compile'
make: *** [build-ci] Error 2
Build step 'Execute shell' marked build as failure
$ ssh-agent -k
unset SSH_AUTH_SOCK;
unset SSH_AGENT_PID;
echo Agent pid 29410 killed;
[ssh-agent] Stopped.
Skipped archiving because build is not successful
Notifying upstream projects of job completion
Finished: FAILUREtest/windows-fanned failure looks unrelatedBuilding the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
FATAL: command execution failed
java.nio.channels.ClosedChannelException
at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:208)
at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:222)
at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:832)
at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecvClosed(SSLEngineFilterLayer.java:181)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.switchToNoSecure(SSLEngineFilterLayer.java:283)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processWrite(SSLEngineFilterLayer.java:503)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processQueuedWrites(SSLEngineFilterLayer.java:248)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doSend(SSLEngineFilterLayer.java:200)
at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.doCloseSend(SSLEngineFilterLayer.java:213)
at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.doCloseSend(ProtocolStack.java:800)
at org.jenkinsci.remoting.protocol.ApplicationLayer.doCloseWrite(ApplicationLayer.java:173)
at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer$ByteBufferCommandTransport.closeWrite(ChannelApplicationLayer.java:311)
at hudson.remoting.Channel.close(Channel.java:1405)
at hudson.remoting.Channel.close(Channel.java:1358)
at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:737)
at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:96)
at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:655)
at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused: java.io.IOException: Backing channel 'JNLP4-connect connection from 104.239.231.190/104.239.231.190:49377' is disconnected.
at hudson.remoting.RemoteInvocationHandler.channelOrFail(RemoteInvocationHandler.java:212)
at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:281)
at com.sun.proxy.$Proxy68.isAlive(Unknown Source)
at hudson.Launcher$RemoteLauncher$ProcImpl.isAlive(Launcher.java:1138)
at hudson.Launcher$RemoteLauncher$ProcImpl.join(Launcher.java:1130)
at hudson.tasks.CommandInterpreter.join(CommandInterpreter.java:155)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:109)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at hudson.model.Build$BuildExecution.build(Build.java:206)
at hudson.model.Build$BuildExecution.doRun(Build.java:163)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
at hudson.model.Run.execute(Run.java:1724)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:421)
Build step 'Execute Windows batch command' marked build as failure
ERROR: Step ‘Publish TAP Results’ failed: no workspace for node-test-binary-windows/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=3 #13578
Checking ^not ok
ERROR: Build step failed with exception
java.lang.NullPointerException
Build step 'Jenkins Text Finder' marked build as failure
Notifying upstream projects of job completion
Finished: FAILURE |
lpinca
approved these changes
Dec 13, 2017
|
Landed in e24ad97 |
danbev
added a commit
that referenced
this pull request
Dec 14, 2017
Currently building test_inspector_socket.cc generates the following
warning:
../test/cctest/test_inspector_socket.cc:189:8: warning:
private field 'disposed_' is not used [-Wunused-private-field]
bool disposed_ = false;
^
1 warning generated.
This commit removes this variable.
PR-URL: #17628
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
Currently building test_inspector_socket.cc generates the following
warning:
../test/cctest/test_inspector_socket.cc:189:8: warning:
private field 'disposed_' is not used [-Wunused-private-field]
bool disposed_ = false;
^
1 warning generated.
This commit removes this variable.
PR-URL: #17628
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
|
putting LTS watch here for 8.x in case future inspector updates make this neccessary |
|
opting to not land, @danbev please feel free to change label and open backport PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently building test_inspector_socket.cc generates the following
warning:
This commit removes this variable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test