Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http2: use actual Timeout instances #17704

Merged
merged 4 commits into from
Dec 20, 2017
Merged

net/http2: use actual Timeout instances #17704

merged 4 commits into from
Dec 20, 2017

Commits on Dec 20, 2017

  1. net: use actual Timeout instance on Sockets 

    This makes `net.Sockets` use actual Timeout objects in a `[kTimeout]`
symbol property, rather than making the socket itself a timer and
appending properties to it directly.

This should make the code generally easier to understand, and might
also prevent some deopts from properties being changes on the socket
itself.

Also moves the Timeout constructor into an internal module.

PR-URL: nodejs#17704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @Fishrock123
    Fishrock123 committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    24dd92e View commit details
    Browse the repository at this point in the history

  2. timers: extract enroll() validation into a fn 

    This should help keep everything consistent.

PR-URL: nodejs#17704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @Fishrock123
    Fishrock123 committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    593941a View commit details
    Browse the repository at this point in the history

  3. http2: use actual Timeout instances 

    This makes `Http2Stream`s and `Http2Session`s use actual Timeout
objects in a [kTimeout] symbol property, rather than making the
stream/session itself a timer and appending properties to it directly.

PR-URL: nodejs#17704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @Fishrock123
    Fishrock123 committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    93eb68e View commit details
    Browse the repository at this point in the history

  4. http2: use session kUpdateTimer from kUpdateTimer 

    Reduces duplicated logic.

PR-URL: nodejs#17704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @Fishrock123
    Fishrock123 committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    fc61ee3 View commit details
    Browse the repository at this point in the history