console: make .assert standard compliant #17706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard has no stack trace. See https://console.spec.whatwg.org/#assert
BridgeAR
added
the
semver-major
nodejs-github-bot
added
the
console
jasnell
approved these changes
Dec 18, 2017
apapirovski
approved these changes
Dec 18, 2017
doc/api/console.md
Outdated
| * `message` {any} | ||
| * `...args` {any} | ||
| * `value` {any} The value tested for being truthy. | ||
| * `...message` {any} All arguments besides the first are used as error message. |
There was a problem hiding this comment.
This feels a tiny bit confusing just because it says "all arguments besides the first." Is there a way we could reword?
There was a problem hiding this comment.
I am open for suggestions ;-)
There was a problem hiding this comment.
Maybe something like "All arguments besides value are used as error message."? Just to make it clear that first = value not the first argument within message.
|
New CI before landing due to weird build failures from before |
|
And a new CI https://ci.nodejs.org/job/node-test-commit-light/50/ |
|
Landed in 15d880b |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Dec 26, 2017
The standard does not throw and has no stack trace. See https://console.spec.whatwg.org/#assert PR-URL: nodejs#17706 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard does not throw and has no stack trace.
See https://console.spec.whatwg.org/#assert
This was mentioned before and the "documentation fix" in #6169 was not seen as a good solution by everyone and I would also prefer the way the standard behaves.
This is clearly a BC but I doubt that this is really a troublemaker.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
console