Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove unused link definition #17741

Closed
wants to merge 1 commit into from
Closed

doc: remove unused link definition #17741

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

@maclover7 maclover7 commented Dec 18, 2017 •
edited
Loading

Causing the linter job to fail on CI right now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@maclover7
doc: remove unused link definition
9796071 
Causing the linter job to fail on CI right now.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Dec 18, 2017
@maclover7 maclover7 mentioned this pull request Dec 18, 2017
Closed
3 tasks
Trott
Trott approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think this needs to wait 48 hours, and might not even need to wait 48 minutes. :-D

@maclover7
Copy link
Contributor Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/32/

@maclover7
Copy link
Contributor Author

Green CI, landing...

@maclover7 maclover7 self-assigned this Dec 18, 2017
maclover7 added a commit to maclover7/node that referenced this pull request Dec 18, 2017
@maclover7
doc: remove unused link definition
ef8accc 
Causing the linter job to fail on CI right now.

PR-URL: nodejs#17741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@maclover7
Copy link
Contributor Author

Landed in ef8accc

@maclover7 maclover7 closed this Dec 18, 2017
@maclover7 maclover7 deleted the jm-rm-link branch December 18, 2017 21:59
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@maclover7 @MylesBorins
doc: remove unused link definition
57c6c31 
Causing the linter job to fail on CI right now.

PR-URL: #17741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@maclover7 @MylesBorins
doc: remove unused link definition
dd9d07c 
Causing the linter job to fail on CI right now.

PR-URL: #17741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@MylesBorins
Copy link
Contributor

The link is still used on 6.x and 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees

@maclover7 maclover7

Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maclover7 @MylesBorins @Trott @cjihrig @nodejs-github-bot