Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: Fix hack by removing redundant + #17803

Closed
wants to merge 1 commit into from
Closed

benchmark: Fix hack by removing redundant + #17803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmark/assert/deepequal-object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ function createObj(source, add = '') {
}

function main(conf) {
const size = +conf.size;
const size = conf.size;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR Can I remove this line and replace size with conf.size as it is only used in two places(31,34)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to, yes. But I think it is not necessary.

// TODO: Fix this "hack"
const n = (+conf.n) / size;
const n = conf.n / size;
var i;

const source = Array.apply(null, Array(size));
Expand Down