Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: make deprecated tls.createSecurePair() use public API #17882

Closed
wants to merge 1 commit into from
Closed

tls: make deprecated tls.createSecurePair() use public API #17882

wants to merge 1 commit into from

Commits on Jan 6, 2018

  1. tls: make deprecated tls.createSecurePair() use public API 

    Make the deprecated `tls.createSecurePair()` method use other public
APIs only (`TLSSocket` in particular).

Since `tls.createSecurePair()` has been runtime-deprecated only
since Node 8, it probably isn’t quite time to remove it yet,
but this patch removes almost all of the code complexity that
is retained by it.

The API, as it is documented, is retained. However, it is very likely
that some users have come to rely on parts of undocumented API
of the `SecurePair` class, especially since some of the existing
tests checked for those. Therefore, this should definitely be
considered a breaking change.
    @addaleax
    addaleax committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    eeae308 View commit details
    Browse the repository at this point in the history