Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve PR-review paragraph in CONTRIBUTING.md #17931

Closed
wants to merge 1 commit into from
Closed

doc: improve PR-review paragraph in CONTRIBUTING.md #17931

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 1, 2018

  • Remove redundant "blocking it or stopping it" as blocking and stopping
    are the same thing in this case.
  • Make another sentence less wordy. Fix incorrect verb conjugation.
    Break into two clear sentences.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@Trott
doc: improve PR-review paragraph in CONTRIBUTING.md
a2a3a70 
* Remove redundant "blocking it or stopping it" as blocking and stopping
  are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
  Break into two clear sentences.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 1, 2018
@maclover7
Copy link
Contributor

Docs CI: https://ci.nodejs.org/job/node-test-pull-request-lite/62/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 2, 2018
@apapirovski
Copy link
Member

Landed in e6a401e

@apapirovski apapirovski closed this Jan 3, 2018
apapirovski pushed a commit that referenced this pull request Jan 3, 2018
@Trott @apapirovski
doc: improve PR-review paragraph in CONTRIBUTING.md
e6a401e 
* Remove redundant "blocking it or stopping it" as blocking and stopping
  are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
  Break into two clear sentences.

PR-URL: #17931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
doc: improve PR-review paragraph in CONTRIBUTING.md
70a727e 
* Remove redundant "blocking it or stopping it" as blocking and stopping
  are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
  Break into two clear sentences.

PR-URL: #17931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
doc: improve PR-review paragraph in CONTRIBUTING.md
26332c0 
* Remove redundant "blocking it or stopping it" as blocking and stopping
  are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
  Break into two clear sentences.

PR-URL: #17931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
doc: improve PR-review paragraph in CONTRIBUTING.md
14499f8 
* Remove redundant "blocking it or stopping it" as blocking and stopping
  are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
  Break into two clear sentences.

PR-URL: #17931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott @MylesBorins
doc: improve PR-review paragraph in CONTRIBUTING.md
d5c8a34 
* Remove redundant "blocking it or stopping it" as blocking and stopping
  are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
  Break into two clear sentences.

PR-URL: #17931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott Trott deleted the style-style-style branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.