crypto: assign deprecation code for setAuthTag/GCM #18017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Jan 6, 2018
jasnell
added
the
semver-major
jasnell
approved these changes
Jan 6, 2018
lpinca
approved these changes
Jan 7, 2018
doc/api/deprecations.md
Outdated
| Node.js supports all GCM authentication tag lengths which are accepted by | ||
| OpenSSL when calling [`decipher.setAuthTag()`][]. This behavior will change in | ||
| a future version at which point only authentication tag lengths of 128, 120, | ||
| 112, 104, 96, 64 and 32 bits will be allowed. Authentication tags whose length |
There was a problem hiding this comment.
Tiny nit: serial comma for consistency.
|
Ping @nodejs/tsc |
targos
approved these changes
Jan 10, 2018
|
Previous CI stopped. New CI: https://ci.nodejs.org/job/node-test-pull-request/12488/ |
tniessen
added a commit
that referenced
this pull request
Jan 14, 2018
PR-URL: #18017 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 858b48b. |
This was referenced Jan 17, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17566 added a warning when invalid GCM tag lengths are used. As a preparation for #17825, assign a deprecation code before moving it to end-of-life.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto